Include React 16 in peerDependencies #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ajoshi0
reviewed
Jan 9, 2018
| @@ -23,7 +23,7 @@ | |||
| "prop-types": "^15.5.7" | |||
| }, | |||
| "peerDependencies": { | |||
| "react": "^0.14.9 || ^15.3.0" | |||
| "react": "^0.14.9 || ^15.3.0 || ^16.0.0" | |||
There was a problem hiding this comment.
@iamdustan can u release this as a patch please
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only adds React 16 to the list of allowed peer dependency versions. Without this change, users of the package are blocked from upgrading to react 16.
I've intentionally not updated the devDependencies for now, but I've updated them locally to test against the latest version. Everything seems fine; tests run and no problems or deprecation warnings inside an actual application.